[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <524e3174-cfff-495c-ba0f-f02d78c2f0bc@linux.intel.com>
Date: Fri, 1 Nov 2024 15:12:48 +0200
From: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To: Philipp Stanner <pstanner@...hat.com>,
William Breathitt Gray <wbg@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] counter: intel-qep: Replace deprecated PCI functions
On 10/28/24 11:13 AM, Philipp Stanner wrote:
> pcim_iomap_regions() and pcim_iomap_table() have been deprecated in
> commit e354bb84a4c1 ("PCI: Deprecate pcim_iomap_table(),
> pcim_iomap_regions_request_all()").
>
> Replace these functions with pcim_iomap_region().
>
> Signed-off-by: Philipp Stanner <pstanner@...hat.com>
> ---
> drivers/counter/intel-qep.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/counter/intel-qep.c b/drivers/counter/intel-qep.c
> index af5942e66f7d..ee2bae27b728 100644
> --- a/drivers/counter/intel-qep.c
> +++ b/drivers/counter/intel-qep.c
> @@ -408,13 +408,9 @@ static int intel_qep_probe(struct pci_dev *pci, const struct pci_device_id *id)
>
> pci_set_master(pci);
>
> - ret = pcim_iomap_regions(pci, BIT(0), pci_name(pci));
> - if (ret)
> - return ret;
> -
> - regs = pcim_iomap_table(pci)[0];
> - if (!regs)
> - return -ENOMEM;
> + regs = pcim_iomap_region(pci, 0, pci_name(pci));
> + if (IS_ERR(regs))
> + return PTR_ERR(regs);
>
> qep->dev = dev;
> qep->regs = regs;
Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Powered by blists - more mailing lists