[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <15f9733b-fe7a-4bf2-a6b9-7f7e04cf26f7@sirena.org.uk>
Date: Fri, 1 Nov 2024 13:15:26 +0000
From: Mark Brown <broonie@...nel.org>
To: Suraj Sonawane <surajsonawane0215@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, linux-sound@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: fix uninit-value in i2s_dma_isr
On Fri, Nov 01, 2024 at 02:32:43PM +0530, Suraj Sonawane wrote:
> I reviewed the context around val_1 and val_2 in dma_addr_next. These values
> are expected to come from the registers when offlevel is non-zero,
> representing the next DMA address and length information. If offlevel is
> zero, it means there’s no offset data to process, and dma_addr_next might
> not need updating in that case.
> A more precise solution would be to conditionally update prtd->dma_addr_next
> only when offlevel is non-zero, as this would reflect the intended logic
> without relying on an arbitrary initialization.
> Would it be better to revise the patch to conditionally update
> prtd->dma_addr_next only when offlevel is non-zero?
> Let me know if this approach aligns better with the expected behavior.
That seems like a reasonable approach, just skip the update when we
didn't read the values.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists