linux-kernel - Re: [PATCH v6 0/6] arm64: dts: qcom: enable Bluetooth and WLAN on sc8280xp and sm8450 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Md=ChXtdAY5_ZGtWQCk06mvtA2pMM2DF03-pb2StvHR7g@mail.gmail.com>
Date: Fri, 1 Nov 2024 15:22:28 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Johan Hovold <johan+linaro@...nel.org>, 
	Kalle Valo <kvalo@...nel.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, 
	Abel Vesa <abel.vesa@...aro.org>, Manivannan Sadhasivam <mani@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-pm@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Steev Klimaszewski <steev@...i.org>
Subject: Re: [PATCH v6 0/6] arm64: dts: qcom: enable Bluetooth and WLAN on
 sc8280xp and sm8450 boards

On Fri, Oct 18, 2024 at 2:49 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> This series previously only concerned sc8280xp but while enabling
> WLAN/BT on sm8450 I noticed some more changes will be required so I
> folded the latter into this series and updated the sc8280xp CRD and X13
> patches.
>
> ==
>
> This models the WLAN and Bluetooth modules on several boards using the
> WCN6855 module.
>
> The wcn6855 (also known as qca6490) is a bit different from the qca6390
> so modify the power sequencing driver to support it with separate device
> match data.
>
> For the sc8280xp-crd and sm8450-hdk we add the PMU, wifi and bluetooth
> nodes with the correctly modelled wiring between them. For the X13s, we
> rework existing nodes so that they align with the new DT bindings
> contract.
>
> On sm8450-hdk we require some additional toggling of the XO-CLK signal
> so add that to the driver as well and update the bindings.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
> Changes in v6:
> - add the xo-clk signal handling to the pwrseq-qcom-wcn driver
> - add a patch enabling wifi and bluetooth on sm8450-hdk
> - add missing supplies to the PMUs on sc8280xp boards
> - Link to v5: https://lore.kernel.org/all/20241008102545.40003-1-brgl@bgdev.pl/
>
> Changes in v5:
> - put vreg_s10b under the "B" PMIC on the CRD instead of modeling it as a
>   fixed regulator
> - order pinctrl nodes alphabetically
> - restore the drive-strength property for all pins to what bootfw sets it to
> - disable bias on wlan-en pin on the CRD
> - remove stray newline
> - add the swctrl pins to the PMU node
>
> Changes in v4:
> - bind bluetooth pins on X13s in patch 3/3
> - only drop the regulator-always-on properties for vreg_s11b and vreg_s12b
>   and fold this change into patch 3/3
>
> Changes in v3:
> - move adding the bt-enable-gpios to the PMU on the CRD to patch 2/4
> - add a patch removing the regulator-always-on property from regulators
>   on X13s that no longer need it
>
> Changes in v2:
> - fix commit message in patch 1/3
> - drop drive-strength from the wlan enable pin function
> - drop the calibration variant property from the wifi node of the CRD
>
> ---
> Bartosz Golaszewski (6):
>       regulator: dt-bindings: qcom,qca6390-pmu: add more properties for wcn6855
>       power: sequencing: qcom-wcn: improve support for wcn6855
>       arm64: dts: qcom: sc8280xp-crd: model the PMU of the on-board wcn6855
>       arm64: dts: qcom: sc8280xp-crd: enable bluetooth
>       arm64: dts: qcom: sc8280xp-x13s: model the PMU of the on-board wcn6855
>       arm64: dts: qcom: sm8450-hdk: model the PMU of the on-board wcn6855
>
>  .../bindings/regulator/qcom,qca6390-pmu.yaml       |  12 ++
>  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts          | 169 +++++++++++++++++++++
>  .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts     | 103 +++++++++++--
>  arch/arm64/boot/dts/qcom/sm8450-hdk.dts            | 157 +++++++++++++++++++
>  arch/arm64/boot/dts/qcom/sm8450.dtsi               |   2 +-
>  drivers/power/sequencing/pwrseq-qcom-wcn.c         | 101 +++++++++++-
>  6 files changed, 526 insertions(+), 18 deletions(-)
> ---
> base-commit: f2493655d2d3d5c6958ed996b043c821c23ae8d3
> change-id: 20240807-sc8280xp-pwrseq-7b6859d846c5
>
> Best regards,
> --
> Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>

It's been two weeks. If there are no objections to the DTS changes,
can the remainder of this series be picked up for v6.13?

Thanks,
Bartosz