linux-kernel - Re: [PATCH v2 3/4] iio: accel: kxcjk-1013: Assing ddata to NULL instead of NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f1f1f24-fa71-4a90-b45f-f09312893e41@web.de>
Date: Fri, 1 Nov 2024 15:45:25 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 linux-iio@...r.kernel.org, Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Dan Carpenter <dan.carpenter@...aro.org>, Jonathan Cameron
 <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v2 3/4] iio: accel: kxcjk-1013: Assing ddata to NULL
 instead of NULL check

> When iio_get_acpi_device_name_and_data() fails, the ddata may be left
> uninitialised. Initialise it to NULL and drop unneeded NULL check
> in kxcjk1013_probe()

I propose to reduce the scope for this local variable.


How do you think about to use a summary phrase like “Replace a pointer check
by a variable initialisation in kxcjk1013_probe()” instead?

Regards,
Markus