linux-kernel - Re: [PATCH v3 0/4] iio: initialise ddata for iio_get_acpi_device_name_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241101145938.304fd98b@jic23-huawei>
Date: Fri, 1 Nov 2024 14:59:38 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Lars-Peter Clausen
 <lars@...afoo.de>
Subject: Re: [PATCH v3 0/4] iio: initialise ddata for
 iio_get_acpi_device_name_and_data()

On Fri,  1 Nov 2024 15:16:00 +0200
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> Dan reported that ddata might be used uninitialised in some cases.
> Let's initialise it to NULL (patches 1 - 3). With that, update one driver
> to drop an unneeded anymore check (included in patch 3).
> 
> While at it, one more cleanup to kxcjk-1013 (patch 4) is added.
> 
> Jonathan, dunno if you want to rebase at this stage (probably not),
> but if you do, feel free to fold the patches 1-3 to the initial code.
Ah. I've just picked v2, but given I squashed anyway the commit message
changes don't matter.  I was curious what Assing meant but not need to
ask given I wasn't going to keep it.


Jonathan

> 
> In v3:
> - made Subject more specific for patches 1-3 (Markus)
> 
> In v2:
> - rewritten patches 1-3 to do the job on the caller side (Jonathan)
> 
> Andy Shevchenko (4):
>   iio: light: isl29018: Assign NULL to ddata in isl29018_probe()
>   iio: light: ltr501: Assign NULL to ddata in ltr501_probe()
>   iio: accel: kxcjk-1013: Assign NULL to ddata in kxcjk1013_probe()
>   iio: accel: kxcjk-1013: Deduplicate ODR startup time array
> 
>  drivers/iio/accel/kxcjk-1013.c | 30 ++++++------------------------
>  drivers/iio/light/isl29018.c   |  2 +-
>  drivers/iio/light/ltr501.c     |  2 +-
>  3 files changed, 8 insertions(+), 26 deletions(-)
>