linux-kernel - RE: [PATCH 1/2] EDAC/igen6: Avoid segmentation fault when rmmod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134B277CF143FB0C5F3002A89572@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Sat, 2 Nov 2024 07:45:06 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Orange Kao <orange@...en.io>, "Luck, Tony" <tony.luck@...el.com>
CC: "bp@...en8.de" <bp@...en8.de>, "james.morse@....com"
	<james.morse@....com>, "orange@...sy.org" <orange@...sy.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mchehab@...nel.org" <mchehab@...nel.org>, "rric@...nel.org"
	<rric@...nel.org>
Subject: RE: [PATCH 1/2] EDAC/igen6: Avoid segmentation fault when rmmod

> From: Orange Kao <orange@...en.io>
> [...]
> Subject: [PATCH 1/2] EDAC/igen6: Avoid segmentation fault when rmmod

This is a bug. Let's fix it. Suggested subject as fellow:

    EDAC/igen6: Fix segmentation fault when rmmod

> The segmentation fault happens because
> During modprobe:
> 1. In igen6_probe(), igen6_pvt will be allocated with kzalloc() 2. In
> igen6_register_mci(), mci->pvt_info will point to
>    &igen6_pvt->imc[mc]
> 
> During rmmod:
> 1. In mci_release() in edac_mc.c, it will kfree(mci->pvt_info) 2. In
> igen6_remove(), it will kfree(igen6_pvt);
> 
> And that caused double kfree on the same memory address. 
> My proposal is to set
> mci->pvt_info to NULL to avoid double-kfree.

Please change the last sentence to:

  Fix this issue by setting mci->pvt_info to NULL to avoid the double kfree.

And append the following tags here:

  Fixes: 10590a9d4f23 ("EDAC/igen6: Add EDAC driver for Intel client SoCs using IBECC")
  Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219360
  Signed-off-by: Orange Kao <orange@...en.io>

Thanks!
-Qiuxu