[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202411021848.djIzD89X-lkp@intel.com>
Date: Sat, 2 Nov 2024 19:07:19 +0800
From: kernel test robot <lkp@...el.com>
To: Jishnu Prakash <quic_jprakash@...cinc.com>, jic23@...nel.org,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, agross@...nel.org, andersson@...nel.org,
dmitry.baryshkov@...aro.org, konrad.dybcio@...aro.org,
daniel.lezcano@...aro.org, sboyd@...nel.org,
quic_subbaram@...cinc.com, quic_collinsd@...cinc.com,
quic_amelende@...cinc.com, quic_kamalw@...cinc.com,
amitk@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, lee@...nel.org,
rafael@...nel.org, rui.zhang@...el.com, lukasz.luba@....com,
lars@...afoo.de, quic_skakitap@...cinc.com,
neil.armstrong@...aro.org, devicetree@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
cros-qcom-dts-watchers@...omium.org,
Jishnu Prakash <quic_jprakash@...cinc.com>
Subject: Re: [PATCH V4 4/4] thermal: qcom: add support for PMIC5 Gen3 ADC
thermal monitoring
Hi Jishnu,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 6fb2fa9805c501d9ade047fc511961f3273cdcb5]
url: https://github.com/intel-lab-lkp/linux/commits/Jishnu-Prakash/dt-bindings-iio-adc-Move-QCOM-ADC-bindings-to-iio-adc-folder/20241031-030237
base: 6fb2fa9805c501d9ade047fc511961f3273cdcb5
patch link: https://lore.kernel.org/r/20241030185854.4015348-5-quic_jprakash%40quicinc.com
patch subject: [PATCH V4 4/4] thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241102/202411021848.djIzD89X-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241102/202411021848.djIzD89X-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411021848.djIzD89X-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/thermal/qcom/qcom-spmi-adc-tm5-gen3.c:104:11: warning: format specifies type 'unsigned int' but the argument has type 'u8 *' (aka 'unsigned char *') [-Wformat]
103 | dev_dbg(adc_tm5->dev, "Interrupt status:%#x, TM status:%#x, high:%#x, low:%#x\n",
| ~~~
| %s
104 | status, tm_status, tm_status[0], tm_status[1]);
| ^~~~~~~~~
include/linux/dev_printk.h:165:39: note: expanded from macro 'dev_dbg'
165 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:274:19: note: expanded from macro 'dynamic_dev_dbg'
274 | dev, fmt, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
250 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
248 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
224 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
1 warning generated.
vim +104 drivers/thermal/qcom/qcom-spmi-adc-tm5-gen3.c
66
67 static irqreturn_t adctm5_gen3_isr(int irq, void *dev_id)
68 {
69 struct adc_tm5_gen3_chip *adc_tm5 = dev_id;
70 u8 status, tm_status[2], val;
71 int ret, sdam_num;
72
73 sdam_num = get_sdam_from_irq(adc_tm5, irq);
74 if (sdam_num < 0) {
75 dev_err(adc_tm5->dev, "adc irq %d not associated with an sdam\n", irq);
76 return IRQ_HANDLED;
77 }
78
79 ret = adc5_gen3_read(adc_tm5->dev_data, sdam_num, ADC5_GEN3_STATUS1, &status, 1);
80 if (ret) {
81 dev_err(adc_tm5->dev, "adc read status1 failed with %d\n", ret);
82 return IRQ_HANDLED;
83 }
84
85 if (status & ADC5_GEN3_STATUS1_CONV_FAULT) {
86 dev_err_ratelimited(adc_tm5->dev, "Unexpected conversion fault, status:%#x\n",
87 status);
88 val = ADC5_GEN3_CONV_ERR_CLR_REQ;
89 adc5_gen3_status_clear(adc_tm5->dev_data, sdam_num, ADC5_GEN3_CONV_ERR_CLR, &val,
90 1);
91 return IRQ_HANDLED;
92 }
93
94 ret = adc5_gen3_read(adc_tm5->dev_data, sdam_num, ADC5_GEN3_TM_HIGH_STS, tm_status, 2);
95 if (ret) {
96 dev_err(adc_tm5->dev, "adc read TM status failed with %d\n", ret);
97 return IRQ_HANDLED;
98 }
99
100 if (tm_status[0] || tm_status[1])
101 schedule_work(&adc_tm5->tm_handler_work);
102
103 dev_dbg(adc_tm5->dev, "Interrupt status:%#x, TM status:%#x, high:%#x, low:%#x\n",
> 104 status, tm_status, tm_status[0], tm_status[1]);
105
106 return IRQ_HANDLED;
107 }
108
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists