linux-kernel - Re: [PATCH v2] perf trace: avoid garbage when not printing a trace event's arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyV0a6e_46R9pmQw@x1>
Date: Fri, 1 Nov 2024 21:38:03 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Benjamin Peterson <benjamin@...flow.com>
Cc: Howard Chu <howardchu95@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	"open list:PERFORMANCE EVENTS SUBSYSTEM" <linux-perf-users@...r.kernel.org>,
	"open list:PERFORMANCE EVENTS SUBSYSTEM" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] perf trace: avoid garbage when not printing a trace
 event's arguments

On Fri, Nov 01, 2024 at 02:41:46PM -0700, Benjamin Peterson wrote:
> On Fri, Nov 1, 2024 at 2:30 PM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > I haven't tested it yet, just in my mind :-)

> > The patch looks ok and seems to fix a real problem, my only concern, a
> > pet peeve, was that it, in addition to fixing a real problem, did an
> > unrelated change, the "Remove the return value...", that part looks like
> > a distraction, something that shouldn't be there.
 
> In my mind, it was related because both the bug and the odd return
> value arise from incorrect counting of the number of written bytes.

> Obviously, the fix is what I care about, so feel free to strip out the
> return value change on import, or I can resend.

The point is to try to focus on the fix, and do just what is needed for
that. Everything else ends up being a distraction.

- Arnaldo