linux-kernel - Re: [PATCH 0/9] Patch set for gpib staging drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024110240-wound-quicken-a70c@gregkh>
Date: Sat, 2 Nov 2024 01:51:35 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Dave Penkler <dpenkler@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org, arnd@...db.de
Subject: Re: [PATCH 0/9] Patch set for gpib staging drivers

On Fri, Nov 01, 2024 at 06:46:56PM +0100, Dave Penkler wrote:
> Patch 1 is a bug fix
> Patches 2-6 replace custom debug with dev_dbg as well as
>             using dev_xxx for pr_xxx where feasible.
> Patch 7 Corrects some errors in Kconfig
> Patch 8 is a code cleanup
> Patch 9 corrects GPIB behaviour
> 
> Dave Penkler (9):
>   Fix buffer overflow in ni_usb_init
>   Replace custom debug with dev_dbg
>   Update messaging and usb_device refs in ni_usb
>   Update messaging and usb_device refs in agilent_usb
>   Remove GPIB_DEBUG reference and update messaging
>   Use dev_xxx for messaging
>   Fix Kconfig
>   Rationalize lookup tables
>   Correct check for max secondary address

The subject lines for all of these need to have something like:
	staging: gpib: ....
as a prefix, otherwise they don't make much sense when looking at all of
the commits in the whole tree.

Can you fix that up, and the other issues pointed out by people, and
send a v2 series?

thanks,

greg k-h