linux-kernel - Re: [PATCH next] lsm: Fix signedness bug in selinux_secid_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b226a01a-2545-4b67-9cc6-59cfa0ffabbc@schaufler-ca.com>
Date: Sat, 2 Nov 2024 10:41:47 -0700
From: Casey Schaufler <casey@...aufler-ca.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Paul Moore <paul@...l-moore.com>,
 Stephen Smalley <stephen.smalley.work@...il.com>,
 Ondrej Mosnacek <omosnace@...hat.com>, selinux@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH next] lsm: Fix signedness bug in selinux_secid_to_secctx()

On 11/2/2024 2:31 AM, Dan Carpenter wrote:
> The "ret" variable needs to be signed for the error checking to work.

Doh.

Thank you.

Acked-by: Casey Schaufler <casey@...aufler-ca.com>

>
> Fixes: 95a3c11eb670 ("lsm: replace context+len with lsm_context")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  security/selinux/hooks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index eca9674c9478..0ff018f557ac 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -6644,7 +6644,7 @@ static int selinux_ismaclabel(const char *name)
>  static int selinux_secid_to_secctx(u32 secid, struct lsm_context *cp)
>  {
>  	u32 seclen;
> -	u32 ret;
> +	int ret;
>  
>  	if (cp) {
>  		cp->id = LSM_ID_SELINUX;