linux-kernel - Re: [PATCH] exec: move warning of null argv to be next to the relevant code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <173057792683.2382793.11435101948652154284.b4-ty@kernel.org>
Date: Sat,  2 Nov 2024 13:05:29 -0700
From: Kees Cook <kees@...nel.org>
To: ebiederm@...ssion.com,
	viro@...iv.linux.org.uk,
	brauner@...nel.org,
	jack@...e.cz,
	linux-mm@...ck.org,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	nir@...htman.org
Cc: Kees Cook <kees@...nel.org>
Subject: Re: [PATCH] exec: move warning of null argv to be next to the relevant code

On Sat, 02 Nov 2024 14:01:22 +0200, nir@...htman.org wrote:
> Problem: The warning is currently printed where it is detected that the
> arg count is zero but the action is only taken place later in the flow
> even though the warning is written as if the action is taken place in
> the time of print
> 
> This could be problematic since there could be a failure between the
> print and the code that takes action which would deem this warning
> misleading
> 
> [...]

Applied to for-next/execve, thanks!

[1/1] exec: move warning of null argv to be next to the relevant code
      https://git.kernel.org/kees/c/cc0be150ca0e

Take care,

-- 
Kees Cook