linux-kernel - Re: [PATCH v4?] ipv6: ip6_fib: fix null-pointer dereference in ipv6_route_native_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9f875ac-d09d-400a-b3f6-140a5792a76d@web.de>
Date: Sun, 3 Nov 2024 09:09:25 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Yi Zou <03zouyi09.25@...il.com>, netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>, 21210240012@...udan.edu.cn,
 21302010073@...udan.edu.cn, David Ahern <dsahern@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4?] ipv6: ip6_fib: fix null-pointer dereference in
 ipv6_route_native_seq_show()

> Check if fib6_nh is non-NULL before accessing fib6_nh->fib_nh_gw_family
> in ipv6_route_native_seq_show() to prevent a null-pointer dereference.
> Assign dev as dev = fib6_nh ? fib6_nh->fib_nh_dev : NULL to ensure safe
> handling when nexthop_fib6_nh(rt->nh) returns NULL.
…
> ---
> net/ipv6/ip6_fib.c | 4 ++--
…

It would have been more appropriate to add also a patch version description.

See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc5#n321

* https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22

Regards,
Markus