linux-kernel - Re: [PATCH net-next v1 2/7] net: page_pool: create page_pool_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d8c55c7-1406-4af6-9dce-0b296cd40fc9@gmail.com>
Date: Sun, 3 Nov 2024 22:35:00 +0800
From: Yunsheng Lin <yunshenglin0825@...il.com>
To: Mina Almasry <almasrymina@...gle.com>,
 Yunsheng Lin <linyunsheng@...wei.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 Ilias Apalodimas <ilias.apalodimas@...aro.org>, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH net-next v1 2/7] net: page_pool: create
 page_pool_alloc_netmem

On 11/1/2024 9:10 PM, Mina Almasry wrote:

...

>>
>> Isn't it a little odd that old and new are not following the same
>> pattern?
> 
> Hi Yunsheng,
> 
> The intention is that page_pool_alloc_pages is mirrored by
> page_pool_alloc_netmems.
> 
> And page_pool_alloc is mirrored by page_pool_alloc_netmem.
> 
>>>From your description, the behavior is the same for each function and
> its mirror. What is the gap in the pattern that you see?

I was mostly referring to the API naming pattern.

Isn't it better if page_pool_alloc is mirrored by netmem_pool_alloc and
netmem_pool_alloc_netmems is mirrored by page_pool_alloc_pages() from
API naming prespective?

And maybe page_pool_alloc_frag can be mirrored by netmem_pool_alloc_frag
in the future?

Also, it would be good to update Documentation/networking/page_pool.rst
for those new netmem APIs, or create a new doc file for them.

>