linux-kernel - Re: [PATCH] modpost: fix acpi MODULE_DEVICE_TABLE built with mismatched endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATz0nOKoZFeFXGii=CcAJ=O+zMV44OYFe+D-CLSJ8GKew@mail.gmail.com>
Date: Mon, 4 Nov 2024 00:01:08 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: linux-kbuild@...r.kernel.org
Cc: Hanjun Guo <guohanjun@...wei.com>, Mika Westerberg <mika.westerberg@...ux.intel.com>, 
	Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, 
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, 
	"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] modpost: fix acpi MODULE_DEVICE_TABLE built with
 mismatched endianness

On Sun, Nov 3, 2024 at 9:56 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> On Sun, Nov 3, 2024 at 9:48 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
> >
> > When CONFIG_SATA_AHCI_PLATFORM=m, modpost outputs incorect MODULE_ALIAS()
> > if the endianness of the target and the build machine do not match.
> >
> > When the endianness of the target kernel and the build machine match,
> > the output is correct:
> >
> >   $ grep 'MODULE_ALIAS("acpi' drivers/ata/ahci_platform.mod.c
> >   MODULE_ALIAS("acpi*:APMC0D33:*");
> >   MODULE_ALIAS("acpi*:010601:*");
> >
> > However, when building a little-endian kernel on a big-endian machine
> > (or vice versa), the output is incorrect:
> >
> >   $ grep 'MODULE_ALIAS("acpi' drivers/ata/ahci_platform.mod.c
> >   MODULE_ALIAS("acpi*:APMC0D33:*");
> >   MODULE_ALIAS("acpi*:0601??:*");
> >
> > The 'cls' and 'cls_msk' fields are 32-bit.
> >
> > DEF_FIELD() must be used instead of DEF_FIELD_ALIAS() to correctly handle
>
> This is a typo:
>
>  DEF_FIELD_ALIAS() -> DEF_FIELD_ADDR()
>

Applied to linux-kbuild/fixes.



-- 
Best Regards
Masahiro Yamada