[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20241103182502.8384-1-jiashengjiangcool@gmail.com>
Date: Sun, 3 Nov 2024 18:25:02 +0000
From: Jiasheng Jiang <jiashengjiangcool@...il.com>
To: fabrice.gasnier@...s.st.com,
wbg@...nel.org,
mcoquelin.stm32@...il.com,
alexandre.torgue@...s.st.com,
Jonathan.Cameron@...wei.com,
benjamin.gaignard@...com,
gregkh@...uxfoundation.org
Cc: linux-iio@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org,
Jiasheng Jiang <jiashengjiangcool@...look.com>
Subject: [PATCH] counter: stm32-timer-cnt: Add check for clk_enable()
From: Jiasheng Jiang <jiashengjiangcool@...look.com>
Add check for the return value of clk_enable() in order to catch the
potential exception.
Fixes: c5b8425514da ("counter: stm32-timer-cnt: add power management support")
Fixes: ad29937e206f ("counter: Add STM32 Timer quadrature encoder")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...look.com>
---
drivers/counter/stm32-timer-cnt.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c
index 186e73d6ccb4..0593c9b73992 100644
--- a/drivers/counter/stm32-timer-cnt.c
+++ b/drivers/counter/stm32-timer-cnt.c
@@ -214,11 +214,15 @@ static int stm32_count_enable_write(struct counter_device *counter,
{
struct stm32_timer_cnt *const priv = counter_priv(counter);
u32 cr1;
+ int ret;
if (enable) {
regmap_read(priv->regmap, TIM_CR1, &cr1);
- if (!(cr1 & TIM_CR1_CEN))
- clk_enable(priv->clk);
+ if (!(cr1 & TIM_CR1_CEN)) {
+ ret = clk_enable(priv->clk);
+ if (ret)
+ return ret;
+ }
regmap_update_bits(priv->regmap, TIM_CR1, TIM_CR1_CEN,
TIM_CR1_CEN);
@@ -816,7 +820,9 @@ static int __maybe_unused stm32_timer_cnt_resume(struct device *dev)
return ret;
if (priv->enabled) {
- clk_enable(priv->clk);
+ ret = clk_enable(priv->clk);
+ if (ret)
+ return ret;
/* Restore registers that may have been lost */
regmap_write(priv->regmap, TIM_SMCR, priv->bak.smcr);
--
2.25.1
Powered by blists - more mailing lists