linux-kernel - Re: [PATCH v2 10/13] arm64: dts: allwinner: a100: perf1: Add eMMC and MMC node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGb2v67RHjq=5DMiP8YtvOww5B8qJxCqF9ofGTXPUkmP-5herA@mail.gmail.com>
Date: Sun, 3 Nov 2024 10:54:55 +0800
From: Chen-Yu Tsai <wens@...e.org>
To: Cody Eksal <masterr3c0rd@...chal.quest>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Jernej Skrabec <jernej.skrabec@...il.com>, 
	Samuel Holland <samuel@...lland.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Kishon Vijay Abraham I <kishon@...nel.org>, Maxime Ripard <mripard@...nel.org>, 
	Michael Turquette <mturquette@...libre.com>, Nishanth Menon <nm@...com>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Stephen Boyd <sboyd@...nel.org>, Vinod Koul <vkoul@...nel.org>, 
	Viresh Kumar <vireshk@...nel.org>, Viresh Kumar <viresh.kumar@...aro.org>, 
	Yangtao Li <tiny.windzz@...il.com>, Parthiban <parthiban@...umiz.com>, 
	Andre Przywara <andre.przywara@....com>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 10/13] arm64: dts: allwinner: a100: perf1: Add eMMC and
 MMC node

On Sun, Nov 3, 2024 at 5:23 AM Cody Eksal <masterr3c0rd@...chal.quest> wrote:
>
> On 2024/11/02 8:48 am, Chen-Yu Tsai wrote:
> > On Thu, Oct 31, 2024 at 3:03 PM Cody Eksal <masterr3c0rd@...chal.quest> wrote:
> >>
> >> From: Yangtao Li <frank@...winnertech.com>
> >>
> >> A100 perf1 hava MicroSD slot and on-board eMMC module, add support for them.
> >>
> >> Signed-off-by: Yangtao Li <frank@...winnertech.com>
> >> Signed-off-by: Cody Eksal <masterr3c0rd@...chal.quest>
> >
> > So I skipped this one since Andre had some questions about the previous
> > mmc clock patch. And I believe this one won't work without it?
> eMMC (mmc2) works fine after more testing, even without the clock
> reparenting patch (in fact, it appears to work more consistently), but
> mmc0 and mmc1 require more testing and debugging. I'll deal with
> the remaining MMC issues in a future patch.

I think it would be better if only the eMMC was enabled. Enabling something
that is almost guaranteed to cause data corruption isn't going to be fun
for users.

ChenYu