linux-kernel - Re: [RFC net-next v01 1/1] net: hinic3: Add a driver for Huawei 3rd gen NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241103141930.271ea070@kernel.org>
Date: Sun, 3 Nov 2024 14:19:30 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Gur Stavi <gur.stavi@...wei.com>
Cc: 'Andrew Lunn' <andrew@...n.ch>, "Gongfan (Eric, Chip)"
 <gongfan1@...wei.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Cai
 Huoqing <cai.huoqing@...ux.dev>, "Guoxin (D)" <guoxin09@...wei.com>,
 shenchenyang <shenchenyang1@...ilicon.com>, "zhoushuai (A)"
 <zhoushuai28@...wei.com>, "Wulike (Collin)" <wulike1@...wei.com>, "shijing
 (A)" <shijing34@...wei.com>, Meny Yossefi <meny.yossefi@...wei.com>
Subject: Re: [RFC net-next v01 1/1] net: hinic3: Add a driver for Huawei 3rd
 gen NIC

On Sun, 3 Nov 2024 22:17:55 +0200 Gur Stavi wrote:
> Breaking a 10KLoC submission into a few 4KLcC (or less) patches helps to
> review specific patches (and ignore other patches) but all lines still need
> to be approved at once so someone must review them.
> 
> Breaking 10KLoC into multiple submissions is easier to review and approve
> (in parts), but merged code will be non-functional until the last
> submission.
> It will compile fine, do no harm, and nobody will pick it except for allyes
> builds.

The driver not being fully functional after the first submission is
fine.

This is a better example, although some parts could have still be
delayed to the second chunk:

https://lore.kernel.org/all/172054602727.1305884.10973465571854855750.stgit@ahduyck-xeon-server.home.arpa/