linux-kernel - Re: [PATCH] drivers/pcwd_pci:Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241104135902.GA2225@www.linux-watchdog.org>
Date: Mon, 4 Nov 2024 14:59:02 +0100
From: Wim Van Sebroeck <wim@...ux-watchdog.org>
To: Zhu Jun <zhujun2@...s.chinamobile.com>
Cc: wim@...ux-watchdog.org, linux@...ck-us.net,
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/pcwd_pci:Fix the wrong format specifier

Hi Zhu,

> The format specifier of "int" in printf() should be "%d", not
> "%u".
> 
> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>
> ---
>  drivers/watchdog/pcwd_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/pcwd_pci.c b/drivers/watchdog/pcwd_pci.c
> index a489b426f2ba..3672e7f23b39 100644
> --- a/drivers/watchdog/pcwd_pci.c
> +++ b/drivers/watchdog/pcwd_pci.c
> @@ -230,7 +230,7 @@ static void pcipcwd_show_card_info(void)
>  	got_fw_rev = send_command(CMD_GET_FIRMWARE_VERSION, &fw_rev_major,
>  								&fw_rev_minor);
>  	if (got_fw_rev)
> -		sprintf(fw_ver_str, "%u.%02u", fw_rev_major, fw_rev_minor);
> +		sprintf(fw_ver_str, "%d.%02d", fw_rev_major, fw_rev_minor);
>  	else
>  		sprintf(fw_ver_str, "<card no answer>");
>  
> -- 
> 2.17.1

%d = The argument is treated as an integer and presented as a (signed) decimal number. 
%u = The argument is treated as an integer and presented as an unsigned decimal number.

I do hope that version number are unsigned...

Kind regards,
Wim.