[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202411042225.evy8ZOph-lkp@intel.com>
Date: Mon, 4 Nov 2024 22:34:54 +0800
From: kernel test robot <lkp@...el.com>
To: David Arinzon <darinzon@...zon.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Paolo Abeni <pabeni@...hat.com>, Shay Agroskin <shayagr@...zon.com>
Subject: drivers/net/ethernet/amazon/ena/ena_netdev.c:77 ena_tx_timeout()
warn: inconsistent indenting
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 59b723cd2adbac2a34fc8e12c74ae26ae45bf230
commit: 071271f39ce833a3534d1fbd47174d1bed6d9326 net: ena: Add more information on TX timeouts
date: 9 months ago
config: i386-randconfig-141-20241104 (https://download.01.org/0day-ci/archive/20241104/202411042225.evy8ZOph-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411042225.evy8ZOph-lkp@intel.com/
smatch warnings:
drivers/net/ethernet/amazon/ena/ena_netdev.c:77 ena_tx_timeout() warn: inconsistent indenting
vim +77 drivers/net/ethernet/amazon/ena/ena_netdev.c
47
48 static void ena_tx_timeout(struct net_device *dev, unsigned int txqueue)
49 {
50 enum ena_regs_reset_reason_types reset_reason = ENA_REGS_RESET_OS_NETDEV_WD;
51 struct ena_adapter *adapter = netdev_priv(dev);
52 unsigned int time_since_last_napi, threshold;
53 struct ena_ring *tx_ring;
54 int napi_scheduled;
55
56 if (txqueue >= adapter->num_io_queues) {
57 netdev_err(dev, "TX timeout on invalid queue %u\n", txqueue);
58 goto schedule_reset;
59 }
60
61 threshold = jiffies_to_usecs(dev->watchdog_timeo);
62 tx_ring = &adapter->tx_ring[txqueue];
63
64 time_since_last_napi = jiffies_to_usecs(jiffies - tx_ring->tx_stats.last_napi_jiffies);
65 napi_scheduled = !!(tx_ring->napi->state & NAPIF_STATE_SCHED);
66
67 netdev_err(dev,
68 "TX q %d is paused for too long (threshold %u). Time since last napi %u usec. napi scheduled: %d\n",
69 txqueue,
70 threshold,
71 time_since_last_napi,
72 napi_scheduled);
73
74 if (threshold < time_since_last_napi && napi_scheduled) {
75 netdev_err(dev,
76 "napi handler hasn't been called for a long time but is scheduled\n");
> 77 reset_reason = ENA_REGS_RESET_SUSPECTED_POLL_STARVATION;
78 }
79 schedule_reset:
80 /* Change the state of the device to trigger reset
81 * Check that we are not in the middle or a trigger already
82 */
83 if (test_and_set_bit(ENA_FLAG_TRIGGER_RESET, &adapter->flags))
84 return;
85
86 ena_reset_device(adapter, reset_reason);
87 ena_increase_stat(&adapter->dev_stats.tx_timeout, 1, &adapter->syncp);
88 }
89
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists