linux-kernel - Re: [PATCH] arm64: dts: qcom: sm8650: Fix CDSP context banks unit addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d7ab244-ca34-4b90-9d9f-39217d3335b5@linaro.org>
Date: Mon, 4 Nov 2024 16:04:41 +0100
From: neil.armstrong@...aro.org
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Ling Xu <quic_lxu5@...cinc.com>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8650: Fix CDSP context banks unit
 addresses

On 04/11/2024 15:42, Krzysztof Kozlowski wrote:
> There is a mismatch between 'reg' property and unit address for last
> there CDSP compute context banks.  Current values were taken as-is from
> downstream source.  Considering that 'reg' is used by Linux driver as
> SID of context bank and that least significant bytes of IOMMU value
> match the 'reg', assume the unit-address is wrong and needs fixing.
> This also won't have any practical impact, except adhering to Devicetree
> spec.
> 
> Fixes: dae8cdb0a9e1 ("arm64: dts: qcom: sm8650: Add three missing fastrpc-compute-cb nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index 3d8a807a81c9..367fdd090768 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -5622,7 +5622,7 @@ compute-cb@8 {
>   
>   					/* note: secure cb9 in downstream */
>   
> -					compute-cb@10 {
> +					compute-cb@12 {
>   						compatible = "qcom,fastrpc-compute-cb";
>   						reg = <12>;
>   
> @@ -5632,7 +5632,7 @@ compute-cb@10 {
>   						dma-coherent;
>   					};
>   
> -					compute-cb@11 {
> +					compute-cb@13 {
>   						compatible = "qcom,fastrpc-compute-cb";
>   						reg = <13>;
>   
> @@ -5642,7 +5642,7 @@ compute-cb@11 {
>   						dma-coherent;
>   					};
>   
> -					compute-cb@12 {
> +					compute-cb@14 {
>   						compatible = "qcom,fastrpc-compute-cb";
>   						reg = <14>;
>   

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>