linux-kernel - Re: [PATCH v4] ACPI: GTDT: Tighten the check for the array of platform timer structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173074012623.2444105.8147260766565910600.b4-ty@arm.com>
Date: Mon,  4 Nov 2024 17:10:26 +0000
From: Catalin Marinas <catalin.marinas@....com>
To: lpieralisi@...nel.org,
	guohanjun@...wei.com,
	sudeep.holla@....com,
	mark.rutland@....com,
	maz@...nel.org,
	rafael@...nel.org,
	lenb@...nel.org,
	Zheng Zengkai <zhengzengkai@...wei.com>
Cc: Will Deacon <will@...nel.org>,
	daniel.lezcano@...aro.org,
	tglx@...utronix.de,
	linux-acpi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] ACPI: GTDT: Tighten the check for the array of platform timer structures

On Wed, 16 Oct 2024 17:54:58 +0800, Zheng Zengkai wrote:
> As suggested by Marc and Lorenzo, first we need to check whether the
> platform_timer entry pointer is within gtdt bounds (< gtdt_end) before
> de-referencing what it points at to detect the length of the platform
> timer struct and then check that the length of current platform_timer
> struct is also valid, i.e. the length is not zero and within gtdt_end.
> Now next_platform_timer() only checks against gtdt_end for the entry of
> subsequent platform timer without checking the length of it and will
> not report error if the check failed and the existing check in function
> acpi_gtdt_init() is also not enough.
> 
> [...]

Applied to arm64 (for-next/misc), thanks!

[1/1] ACPI: GTDT: Tighten the check for the array of platform timer structures
      https://git.kernel.org/arm64/c/263e22d6bd1f

-- 
Catalin