lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87ikt294v6.fsf@trenco.lwn.net>
Date: Mon, 04 Nov 2024 12:27:25 -0700
From: Jonathan Corbet <corbet@....net>
To: xu.xin16@....com.cn, alexs@...nel.org, si.yanteng@...ux.dev,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 mudongliangabcd@...il.com, seakeel@...il.com
Cc: wang.yaxin@....com.cn, fan.yu9@....com.cn, xu.xin16@....com.cn,
 he.peilin@....com.cn, tu.qiang35@....com.cn, qiu.yutan@....com.cn,
 zhang.yunkai@....com.cn
Subject: Re: [PATCH linux-next v8 RESEND] Docs/zh_CN: Translate
 physical_memory.rst to Simplified Chinese

OK, I have applied this patch.  A couple of comments for future reference:

<xu.xin16@....com.cn> writes:

> From: Yaxin Wang <wang.yaxin@....com.cn>
>
> This patch translates the "physical_memory.rst" document into
> Simplified Chinese to improve accessibility for Chinese-speaking
> developers and users.

Our documentation requests that patch changelogs be phrased in the
imperative tense and avoid terms like "this patch".  Some maintainers
are quite insistent about that; I'm not one of them, but it is better to
follow that guidance.

> The translation was done with attention to technical accuracy
> and readability, ensuring that the document remains informative
> and useful in its translated form.

This is not helpful in a changelog; if you have not paid such attention,
you should not be submitting the patch in the first place.  Comments
like this can go after the "---" line if you really need to include
them. 

> Update to commit 7332f9e45d2e("docs/mm: Physical Memory: Fix grammar")

...and this I don't understand at all; why do you need to reference that
patch here?

Thanks,

jon

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ