linux-kernel - Re: [PATCH] counter: ti-ecap-capture: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241104193128.41871-1-jiashengjiangcool@gmail.com>
Date: Mon,  4 Nov 2024 19:31:28 +0000
From: Jiasheng Jiang <jiashengjiangcool@...il.com>
To: wbg@...nel.org,
	vigneshr@...com,
	jpanis@...libre.com,
	gregkh@...uxfoundation.org
Cc: linux-iio@...r.kernel.org,
	linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Jiasheng Jiang <jiashengjiangcool@...il.com>
Subject: Re: [PATCH] counter: ti-ecap-capture: Add check for clk_enable()

On Mon, Nov 04, 2024 at 09:28:00AM -0500, William Breathitt Gray wrote:
> On Sun, Nov 03, 2024 at 09:39:10PM +0000, Jiasheng Jiang wrote:
>	Add check for the return value of clk_enable() in order to catch the
>	potential exception.
>
>	Fixes: 4e2f42aa00b6 ("counter: ti-ecap-capture: capture driver support for ECAP")
>	Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...il.com>
>	---
>	drivers/counter/ti-ecap-capture.c | 5 ++++-
>	1 file changed, 4 insertions(+), 1 deletion(-)
>
>	diff --git a/drivers/counter/ti-ecap-capture.c b/drivers/counter/ti-ecap-capture.c
>	index 675447315caf..30a269fa5da0 100644
>	--- a/drivers/counter/ti-ecap-capture.c
>	+++ b/drivers/counter/ti-ecap-capture.c
>	@@ -574,8 +574,11 @@ static int ecap_cnt_resume(struct device *dev)
>	{
>		struct counter_device *counter_dev = dev_get_drvdata(dev);
>		struct ecap_cnt_dev *ecap_dev = counter_priv(counter_dev);
>	+	int ret;
>
>	-	clk_enable(ecap_dev->clk);
>	+	ret = clk_enable(ecap_dev->clk);
>	+	if (ret)
>	+		return ret;
>
>		ecap_cnt_capture_set_evmode(counter_dev, ecap_dev->pm_ctx.ev_mode);
>
>	--
>	2.25.1
>
> Similar to the stm32-timer-cnt patch comment: it's not necessarily clear
> that an error in the cnt_resume() callback is due to a clk_enable()
> failure, so you should call dev_err() before returning to indicate the
> reason for the error code.

Thanks, I will add dev_err() in my v2 patches.

-Jiasheng Jiang