linux-kernel - Re: [PATCH 1/1] arm64: dts: imx8mq-zii-ultra: remove #address-cells of eeprom@a4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZykwYD67p+Oug/kG@lizhi-Precision-Tower-5810>
Date: Mon, 4 Nov 2024 15:36:48 -0500
From: Frank Li <Frank.li@....com>
To: Shawn Guo <shawnguo2@...h.net>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] arm64: dts: imx8mq-zii-ultra: remove #address-cells
 of eeprom@a4

On Fri, Nov 01, 2024 at 04:47:17PM +0800, Shawn Guo wrote:
> On Fri, Oct 18, 2024 at 02:31:16PM -0400, Frank Li wrote:
> > Remove #address-cells and #size-cells of eeprom@a4 because no children
> > nodes under eeprom@a4.
>
> Hmm, bindings/nvmem/zii,rave-sp-eeprom.txt suggests there could be child
> nodes?

"Data cells are child nodes of eerpom node, bindings for which are
documented in Documentation/devicetree/bindings/nvmem/nvmem.txt"

It should be optional property to declear offset, such as mac_address, or
watchdog_timeout value.

Here is no children nodes under eeprom@a4, so needn't #address-cells. It
should be added only when add children nodes.

Frank

>
> Shawn
>
> >
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > index 0c960efd9b3d5..c7bbba45f3685 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > @@ -517,8 +517,6 @@ eeprom@a3 {
> >  		eeprom@a4 {
> >  			compatible = "zii,rave-sp-eeprom";
> >  			reg = <0xa4 0x4000>;
> > -			#address-cells = <1>;
> > -			#size-cells = <1>;
> >  			zii,eeprom-name = "main-eeprom";
> >  		};
> >  	};
> > --
> > 2.34.1
> >
>