linux-kernel - Re: [PATCH v3 3/4] crypto: ccp: Add SNP firmware hotload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0a5d1a6-39ef-2637-ece0-387582b09fcc@amd.com>
Date: Mon, 4 Nov 2024 14:45:43 -0600
From: Tom Lendacky <thomas.lendacky@....com>
To: Dionna Amalie Glaze <dionnaglaze@...gle.com>
Cc: linux-kernel@...r.kernel.org, x86@...nel.org,
 John Allen <john.allen@....com>, Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>, Ashish Kalra
 <ashish.kalra@....com>, Sean Christopherson <seanjc@...gle.com>,
 Paolo Bonzini <pbonzini@...hat.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Michael Roth <michael.roth@....com>, Luis Chamberlain <mcgrof@...nel.org>,
 Russ Weight <russ.weight@...ux.dev>, Danilo Krummrich <dakr@...hat.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Tianfei zhang <tianfei.zhang@...el.com>, Alexey Kardashevskiy <aik@....com>,
 linux-crypto@...r.kernel.org
Subject: Re: [PATCH v3 3/4] crypto: ccp: Add SNP firmware hotload support

On 11/4/24 13:30, Dionna Amalie Glaze wrote:
> On Mon, Nov 4, 2024 at 9:06 AM Tom Lendacky <thomas.lendacky@....com> wrote:
>> On 11/1/24 19:08, Dionna Glaze wrote:
>>

>> This is a big patch. Can you split this up into smaller patches? At a
>> minimum, one patch that adds the context tracking and one that adds the
>> firmware support.
>>
> 
> Can do. Would it be appropriate to also add a sysfs attribute group
> for sev that makes the firmware version more easily readable? Or
> should I put that in a follow-up chain?

That would be best as a separate patch series. But doesn't the
SEV_PLATFORM_STATUS or SNP_PLATFORM_STATUS ioctl() give you all the
information you need?

Thanks,
Tom

> The dmesg log about the firmware version isn't the best for writing
> automation for managing firmware hotloading at scale, and we're better
> set up for working with sysfs generally.
> 
>> Also, can the guest context page tracking and new firmware related
>> functions be placed in a new file, sev-fw.c or similar, that is
>> conditionally built based on CONFIG_FW_UPLOAD. Then a header file can be
>> used to provide the different implementations of the new functions
>> removing the #ifdefs from the code.
>>
>> Thanks,
>> Tom
>>