linux-kernel - Re: [PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes to async flip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00a99b3e-3fad-42fb-8dc8-4f45d158c4c1@igalia.com>
Date: Mon, 4 Nov 2024 17:52:43 -0300
From: André Almeida <andrealmeid@...lia.com>
To: Christopher Snowhill <chris@...e54.net>
Cc: kernel-dev@...lia.com, Simon Ser <contact@...rsion.fr>,
 Thomas Zimmermann <tzimmermann@...e.de>, joshua@...ggi.es,
 ville.syrjala@...ux.intel.com, Daniel Stone <daniel@...ishbar.org>,
 Xaver Hugl <xaver.hugl@...il.com>, Harry Wentland <harry.wentland@....com>,
 Simona Vetter <simona@...ll.ch>, Alex Deucher <alexander.deucher@....com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
 Leo Li <sunpeng.li@....com>, Christian König
 <christian.koenig@....com>, David Airlie <airlied@...il.com>,
 Rodrigo Siqueira <Rodrigo.Siqueira@....com>, Xinhui Pan
 <Xinhui.Pan@....com>, dmitry.baryshkov@...aro.org
Subject: Re: [PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes
 to async flip

Hi Christopher,

Em 03/11/2024 03:36, Christopher Snowhill escreveu:
> On Fri Nov 1, 2024 at 11:23 AM PDT, André Almeida wrote:
>> Currently, DRM atomic uAPI allows only primary planes to be flipped
>> asynchronously. However, each driver might be able to perform async
>> flips in other different plane types. To enable drivers to set their own
>> restrictions on which type of plane they can or cannot flip, use the
>> existing atomic_async_check() from struct drm_plane_helper_funcs to
>> enhance this flexibility, thus allowing different plane types to be able
>> to do async flips as well.
>>
>> In order to prevent regressions and such, we keep the current policy: we
>> skip the driver check for the primary plane, because it is always
>> allowed to do async flips on it.
>>
>> Signed-off-by: André Almeida <andrealmeid@...lia.com>
> 
> Should I do a R-b too? 

If you can review the code, it's always really appreciated.

> The changes looked sound enough for me to feel
> like testing it as well. Tested Borderlands Game of the Year Enhanced on
> my RX 7700 XT at maximum settings at 1080p165, and the tearing support in
> labwc allowed it to reach over 700fps. No problems from the hardware
> cursor.

Thanks for testing and reporting!

> 
> Tested-by: Christopher Snowhill <chris@...e54.net>
>