linux-kernel - Re: [PATCH 4/5] arm64: dts: qcom: Add base sm8750 dtsi and mtp and qrd dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2d34549-b433-4126-b61b-912109de7d33@quicinc.com>
Date: Mon, 4 Nov 2024 14:18:10 -0800
From: Melody Olvera <quic_molvera@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>, Lee Jones <lee@...nel.org>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Geert Uytterhoeven
	<geert+renesas@...der.be>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
        "Neil
 Armstrong" <neil.armstrong@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Nícolas F . R . A . Prado <nfraprado@...labora.com>,
        Stephen Boyd <sboyd@...nel.org>, Trilok Soni <quic_tsoni@...cinc.com>,
        "Satya
 Durga Srinivasu Prabhala" <quic_satyap@...cinc.com>
CC: <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        Taniya Das <quic_tdas@...cinc.com>,
        Jishnu Prakash
	<quic_jprakash@...cinc.com>,
        Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
Subject: Re: [PATCH 4/5] arm64: dts: qcom: Add base sm8750 dtsi and mtp and
 qrd dts



On 11/2/2024 2:36 AM, Konrad Dybcio wrote:
> On 22.10.2024 1:21 AM, Melody Olvera wrote:
>> Add base dtsi for the sm8750 SoC describing the CPUs, GCC and
>> RPMHCC clock controllers, geni UART, interrupt controller, TLMM,
>> reserved memory, interconnects, regulator, and SMMU nodes. Also add
>> MTP and QRD board dts files for sm8750.
>>
>> Co-developed-by: Taniya Das <quic_tdas@...cinc.com>
>> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
>> Co-developed-by: Jishnu Prakash <quic_jprakash@...cinc.com>
>> Signed-off-by: Jishnu Prakash <quic_jprakash@...cinc.com>
>> Co-developed-by: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
>> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
>> Signed-off-by: Melody Olvera <quic_molvera@...cinc.com>
>> ---
> [...]
>
>> +&spmi_bus {
>> +	pm8550ve_d: pmic@3 {
> These usually go to a separate file each.. But I see why that would
> be difficult here.
>
> Lately I've been a fan of <socname>-pmics.dtsi. WDYT, Bjorn?

SGTM, if Bjorn is fine w it, I can make that change; I'll do it similar 
to x1e80100-pmics.dtsi.

>
> [...]
>
>> +		apps_smmu: iommu@...00000 {
>> +			compatible = "qcom,sm8750-smmu-500", "qcom,smmu-500", "arm,mmu-500";
>> +			reg = <0x0 0x15000000 0x0 0x100000>;
>> +
> [...]
>
>> +			#iommu-cells = <2>;
>> +			#global-interrupts = <1>;
> This is usually dma-coherent, you can determine that through a smoke
> test

Ah yes good catch; this is supposed to be dma-coherent. Will add.

>
>> +		};
>> +
>> +		intc: interrupt-controller@...00000 {
>> +			compatible = "arm,gic-v3";
>> +			reg = <0x0 0x16000000 0x0 0x10000>,     /* GICD */
>> +			      <0x0 0x16080000 0x0 0x200000>;    /* GICR * 12 */
> These comments are copypasted gen to gen and don't bring much
> information atop what's in bindings
>

Ack. Will remove.

Thanks,
Melody