[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <945f3eae-0a68-4738-af07-74e228039508@quicinc.com>
Date: Mon, 4 Nov 2024 10:01:03 +0530
From: Krishna Kurapati <quic_kriskura@...cinc.com>
To: <jens.glathe@...schoolsolutions.biz>,
Bjorn Andersson
<andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, Merck Hung <merckhung@...il.com>,
Kalle Valo
<kvalo@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski
<krzk+dt@...nel.org>,
Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v7 3/3] arm64: dts: qcom: sc8280xp-blackrock: dt
definition for WDK2023
On 11/1/2024 11:56 PM, Jens Glathe via B4 Relay wrote:
> From: Jens Glathe <jens.glathe@...schoolsolutions.biz>
>
> Device tree for the Microsoft Windows Dev Kit 2023. This work
> is based on the initial work of Merck Hung <merckhung@...il.com>.
>
> Original work: https://github.com/merckhung/linux_ms_dev_kit/blob/ms-dev-kit-2023-v6.3.0/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-dev-kit-2023.dts
>
> The Windows Dev Kit 2023 is a nice little desktop based on sc8280xp.
> Link: https://learn.microsoft.com/en-us/windows/arm/dev-kit/
>
> Supported features:
> - USB type-c and type-a ports
> - minidp connector
> - built-in r8152 Ethernet adapter
> - PCIe devices
> - nvme
> - ath11k WiFi (WCN6855)
> - WCN6855 Bluetooth
> - A690 GPU
> - ADSP and CDSP
> - GPIO keys
> - Audio definition (works via USB)
>
> Signed-off-by: Jens Glathe <jens.glathe@...schoolsolutions.biz>
> ---
[...]
> +&usb_2 {
> + pinctrl-0 = <&usb2_en_state>;
> + pinctrl-names = "default";
> +
On the blackrock platform, for this controller, are there all 4 ports
given out for use or only one ?
Because if all 4 are there, you might need to give all 4 pinctrls (one
for each TS3USB221A mux select) here for usb_2 node. If only one port is
given out for use on the platform, then only one phy (of the 4 activated
below) needs to be marked as active.
In my case, in [1] on the ADP platform, I marked them as always on for
all gpios on multiport controller since driver had no support added yet.
[1]:
https://lore.kernel.org/all/20240707085624.3411961-1-quic_kriskura@quicinc.com/
> + status = "okay";
> +};
> +
> +&usb_2_hsphy0 {
> + vdda-pll-supply = <&vreg_l1b>;
> + vdda18-supply = <&vreg_l1c>;
> + vdda33-supply = <&vreg_l7d>;
> +
> + status = "okay";
> +};
> +
> +&usb_2_hsphy1 {
> + vdda-pll-supply = <&vreg_l8d>;
> + vdda18-supply = <&vreg_l1c>;
> + vdda33-supply = <&vreg_l7d>;
> +
> + status = "okay";
> +};
> +
> +&usb_2_hsphy2 {
> + vdda-pll-supply = <&vreg_l10d>;
> + vdda18-supply = <&vreg_l8c>;
> + vdda33-supply = <&vreg_l2d>;
> +
> + status = "okay";
> +};
> +
> +&usb_2_hsphy3 {
> + vdda-pll-supply = <&vreg_l10d>;
> + vdda18-supply = <&vreg_l8c>;
> + vdda33-supply = <&vreg_l2d>;
> +
> + status = "okay";
> +};
> +
> +&usb_2_qmpphy0 {
> + vdda-phy-supply = <&vreg_l1b>;
> + vdda-pll-supply = <&vreg_l4d>;
> +
> + status = "okay";
> +};
> +
> +&usb_2_qmpphy1 {
> + vdda-phy-supply = <&vreg_l8d>;
> + vdda-pll-supply = <&vreg_l4d>;
> +
> + status = "okay";
> +};
> +
[...]
> + usb2_en_state: usb2-en-state {
> + /* TS3USB221A USB2.0 mux select */
> + pins = "gpio24";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + output-low;
> + };
> +
Regards,
Krishna,
Powered by blists - more mailing lists