linux-kernel - Re: [PATCH v2] arm64: dts: ti: k3-am62: use opp_efuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241104045227.2tzm2lcwi7kqee5r@lcpd911>
Date: Mon, 4 Nov 2024 10:22:27 +0530
From: Dhruva Gole <d-gole@...com>
To: Vignesh Raghavendra <vigneshr@...com>
CC: Nishanth Menon <nm@...com>, <linux-pm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>, Bryan Brattlof <bb@...com>,
        Wadim
 Egorov <w.egorov@...tec.de>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am62: use opp_efuse_table for
 opp-table syscon

On Oct 30, 2024 at 11:17:16 +0530, Vignesh Raghavendra wrote:
> Hi
> 
> On 30/10/24 10:15, Dhruva Gole wrote:
> > Add another entry in the wkup_conf for the syscon node, and then use
> > that for the syscon in opp-table.
> > 
> > Marking entire wkup_conf as "syscon", "simple-mfd" is wrong and needs to
> > be addressed similar to how other child-nodes in wkup_conf are implemented
> > in the same file.
> > 
> > Signed-off-by: Dhruva Gole <d-gole@...com>
> > ---
> > 
> > Since the driver fixes for ti-cpufreq.c have made it in -next [1],
> > The DT fixes for SK-AM62x can be supported with support for legacy
> > style DT as well. This has been tested on SK-AM62x [2]
> > 
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/cpufreq/ti-cpufreq.c?id=1724ae88efcbcd0daeb203ffeb4a2c0e59f2ddf7
> > [2] https://gist.github.com/DhruvaG2000/40b80cc04a9ac90c86445d6e67ece4cb
> > 
> > Changelog:
> > 
> > Changes in v2:
> > - Deleted PATCH to Make the AM625 efuse_offset 0, because with [1] we no
> >   longer break backward compatibility and hence need to preserve the old
> >   offset.
> > - Link to v1:
> >   https://lore.kernel.org/linux-arm-kernel/20240902093222.2828345-3-d-gole@ti.com/
> > 
> > ---
> >  arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 7 ++++++-
> >  arch/arm64/boot/dts/ti/k3-am625.dtsi       | 2 +-
> >  2 files changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> > index e0afafd532a5..b2b65e31c7cf 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> > @@ -10,7 +10,7 @@
> >  &cbass_wakeup {
> >  	wkup_conf: syscon@...00000 {
> 
> Now that the compatible is updated, this needs to be bus@...r
> dtbs_check should catch such errors.

Oh yes, I'll update this. Good catch.

> 
> >  		bootph-all;
> > -		compatible = "syscon", "simple-mfd";
> > +		compatible = "simple-bus";
> 
> Did you also check U-Boot and make sure no regression/update needed?
> 

No, I can do a quick sanity boot till kernel with this DTB in U-boot to
check for regressions.

Thanks for the review.

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated