linux-kernel - RE: [PATCH net 2/2] net: xilinx: axienet: Check if Tx queue enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BL3PR12MB6571B8EF92F67BA98DF1B07AC9512@BL3PR12MB6571.namprd12.prod.outlook.com>
Date: Mon, 4 Nov 2024 07:08:23 +0000
From: "Gupta, Suraj" <Suraj.Gupta2@....com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "Simek, Michal"
	<michal.simek@....com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "git (AMD-Xilinx)" <git@....com>, "Katakam,
 Harini" <harini.katakam@....com>
Subject: RE: [PATCH net 2/2] net: xilinx: axienet: Check if Tx queue enabled



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Monday, November 4, 2024 4:07 AM
> To: Gupta, Suraj <Suraj.Gupta2@....com>
> Cc: Pandey, Radhey Shyam <radhey.shyam.pandey@....com>;
> andrew+netdev@...n.ch; davem@...emloft.net; edumazet@...gle.com;
> pabeni@...hat.com; Simek, Michal <michal.simek@....com>;
> netdev@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; git (AMD-Xilinx) <git@....com>; Katakam, Harini
> <harini.katakam@....com>
> Subject: Re: [PATCH net 2/2] net: xilinx: axienet: Check if Tx queue enabled
> 
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
> 
> 
> On Wed, 30 Oct 2024 11:55:33 +0530 Suraj Gupta wrote:
> > Check return value of netif_txq_maybe_stop() in transmit direction and
> > start dma engine only if queue is enabled.
> 
> The first patch makes sense, let me apply that one.
> But this one I don't understand - what is the problem you're trying to fix?
> netif_txq_maybe_stop() tries to stop the queue if the *next* packet may not fit in the
> queue. The currently processed packet is assumed to have already been queued.

I was under impression that it tries to stop if "current" packet may not fit in the queue. This check won't be required then, thanks for applying first patch.

Regards,
Suraj