linux-kernel - Re: [PATCH v2] btrfs: handle bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <726be3e6-5b1c-4a98-9b1d-247dc86195ac@wdc.com>
Date: Mon, 4 Nov 2024 07:24:05 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: John Garry <john.g.garry@...cle.com>, Johannes Thumshirn <jth@...nel.org>,
	Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>, David Sterba
	<dsterba@...e.com>, "open list:BTRFS FILE SYSTEM"
	<linux-btrfs@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
CC: "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>, Dan Carpenter
	<dan.carpenter@...aro.org>
Subject: Re: [PATCH v2] btrfs: handle bio_split() error

On 01.11.24 17:24, John Garry wrote:
>>    
>>    	if (map_length < length) {
>>    		bbio = btrfs_split_bio(fs_info, bbio, map_length);
>> +		if (IS_ERR(bbio)) {
>> +			ret = errno_to_blk_status(PTR_ERR(bbio));
> 
> btrfs_split_bio() does splitting, but error means "goto fail". However
> other failure points "goto fail_split". I find that label naming odd.
> 
> Furthermore, at "fail", we call btrfs_bio_end_io() and that function
> dereferences bbio (which is -EINVAL or something like that)

OK, my stupidity doing something that should be as simple as this patch 
is getting embarrassing.

I'll send a v3 soon.