linux-kernel - Re: [PATCH] media: atomisp: Add check for rgby

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae357384-284d-623f-b904-c0115cdda844@huawei.com>
Date: Mon, 4 Nov 2024 15:30:14 +0800
From: Li Huafei <lihuafei1@...wei.com>
To: Andy Shevchenko <andy@...nel.org>
CC: <mchehab@...nel.org>, <hdegoede@...hat.com>,
	<sakari.ailus@...ux.intel.com>, <gregkh@...uxfoundation.org>,
	<linux-media@...r.kernel.org>, <linux-staging@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: atomisp: Add check for rgby_data memory allocation
 failure



On 2024/11/1 18:55, Andy Shevchenko wrote:
> On Fri, Nov 01, 2024 at 12:16:03PM +0200, Andy Shevchenko wrote:
>> On Fri, Nov 01, 2024 at 05:57:36PM +0800, Li Huafei wrote:
>>> On 2024/11/1 16:30, Andy Shevchenko wrote:
>>>> On Fri, Nov 01, 2024 at 11:48:23PM +0800, Li Huafei wrote:
>>>>> In ia_css_3a_statistics_allocate(), there is no check on the allocation
>>>>> result of the rgby_data memory. If rgby_data is not successfully
>>>>> allocated, it may trigger the assert(host_stats->rgby_data) assertion in
>>>>> ia_css_s3a_hmem_decode(). Adding a check to fix this potential issue.
>>>>
>>>> Not sure if this code even run on currently supported hardware / firmware,
>>>> but fix looks okay.
>>>>
>>>>> Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
>>>>
>>>> No, this is an intermediate commit, you should find the original, which is
>>>> earlier in the history.
>>>
>>> Apologies, the correct fix tag should be:
>>>
>>> Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
>>>
>>> If this fix can be applied, do I need to send a v2, or can you help add the Fix tag?
>>
>> Up to Hans, but there is another question left unanswered about SoB chain.
>> Can you clarify that?
> 
> Ah, sorry, I misread the From and answered to the wrong thread.
> Fixes tag seems better now.
> 
Okay, I have sent v2:

v2: https://lore.kernel.org/lkml/20241104145051.3088231-1-lihuafei1@huawei.com/

Thanks,
Huafei