[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4e5a3f32-f959-8106-ac32-f802353dbcf6@denx.de>
Date: Mon, 4 Nov 2024 08:54:38 +0100
From: Heiko Schocher <hs@...x.de>
To: Shawn Guo <shawnguo2@...h.net>
Cc: linux-kernel@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
Fabio Estevam <festevam@...il.com>, Krzysztof Kozlowski
<krzk+dt@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Rob Herring <robh@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: dts: imx8mp: add aristainetos3 board
support
Hello Shawn,
On 04.11.24 08:13, Shawn Guo wrote:
> On Mon, Nov 04, 2024 at 06:33:55AM +0100, Heiko Schocher wrote:
>>>> +
>>>> + semtech,probe-reset;
>>>> + gpio-controller;
>>>> + interrupt-controller;
>>>> +
>>>> + interrupt-parent = <&gpio1>;
>>>> + interrupts = <12 IRQ_TYPE_EDGE_FALLING>;
>>>> + };
>>
>> Should I remove newlines here too?... but looking into the example from
>>
>> Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml
>>
>> there are this newlines ... so I let this lines in... or?
>
> Not having newlines in middle of property list is just a style that
> I prefer for IMX device trees.
I remove them too than!
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@...x.de
Powered by blists - more mailing lists