linux-kernel - Re: [PATCH v6 2/2] hwmon: Add driver for I2C chip Nuvoton NCT7363Y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALz278ZtciLq3gVyB_66zNPDh+n2oypLOmVSUQq4yR5sO-CoNg@mail.gmail.com>
Date: Mon, 4 Nov 2024 16:20:25 +0800
From: Ban Feng <baneric926@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>, jdelvare@...e.com, robh+dt@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, corbet@....net, 
	linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, 
	openbmc@...ts.ozlabs.org, kwliu@...oton.com, kcfeng0@...oton.com, 
	DELPHINE_CHIU@...ynn.com, Bonnie_Lo@...ynn.com
Subject: Re: [PATCH v6 2/2] hwmon: Add driver for I2C chip Nuvoton NCT7363Y

On Tue, Oct 22, 2024 at 11:14 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On 10/22/24 00:20, Christophe JAILLET wrote:
> [ ... ]
> >> +    hwmon_dev =
> >> +        devm_hwmon_device_register_with_info(dev, client->name, data,
> >> +                             &nct7363_chip_info, NULL);
> >
> > return devm_hwmon_device_register_with_info()?
> >
>
> No, because the function needs to return an integer, not a pointer.
> And
>         return PTR_ERR_OR_ZERO(devm_hwmon_device_register_with_info(...));
> would look a bit awkward.
>
> Guenter
>

Hi Guenter and Christophe,

I'll keep following this driver and check with these suggestions.

Thanks,
Ban