linux-kernel - Re: [PATCH 1/3] media: i2c: imx219: Correct the minimum vblanking value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p75bv6cdt3xuiticrw4qlrma62idasocvflpyv424r5gmqwssz@4jed7vwesukf>
Date: Mon, 4 Nov 2024 09:33:16 +0100
From: Jacopo Mondi <jacopo.mondi@...asonboard.com>
To: Jai Luthra <jai.luthra@...asonboard.com>
Cc: Dave Stevenson <dave.stevenson@...pberrypi.com>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	David Plowman <david.plowman@...pberrypi.com>
Subject: Re: [PATCH 1/3] media: i2c: imx219: Correct the minimum vblanking
 value

Hi Jai

On Tue, Oct 29, 2024 at 02:27:35PM +0530, Jai Luthra wrote:
> From: David Plowman <david.plowman@...pberrypi.com>
>
> The datasheet for this sensor documents the minimum vblanking as being
> 32 lines. It does fix some problems with occasional black lines at the
> bottom of images (tested on Raspberry Pi).
>
> Signed-off-by: David Plowman <david.plowman@...pberrypi.com>
> Signed-off-by: Jai Luthra <jai.luthra@...asonboard.com>

Confirmed by the documentation of register 0x114a/0x114b

Reviewed-by: Jacopo Mondi <jacopo.mondi@...asonboard.com>

> ---
>  drivers/media/i2c/imx219.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index e78a80b2bb2e455c857390b188c128b28c224778..f98aad74fe584a18e2fe7126f92bf294762a54e3 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -74,7 +74,7 @@
>  #define IMX219_REG_VTS			CCI_REG16(0x0160)
>  #define IMX219_VTS_MAX			0xffff
>
> -#define IMX219_VBLANK_MIN		4
> +#define IMX219_VBLANK_MIN		32
>
>  /* HBLANK control - read only */
>  #define IMX219_PPL_DEFAULT		3448
>
> --
> 2.47.0
>
>