[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZyiIp6t53FN9ssyV@smile.fi.intel.com>
Date: Mon, 4 Nov 2024 10:41:11 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Aren Moynihan <aren@...cevolution.org>
Cc: Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
Kaustabh Chakraborty <kauschluss@...root.org>,
Barnabás Czémán <trabarni@...il.com>,
Ondrej Jirman <megi@....cz>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, Dragan Simic <dsimic@...jaro.org>,
phone-devel@...r.kernel.org
Subject: Re: [PATCH v4 5/6] iio: light: stk3310: log error if reading the
chip id fails
On Sat, Nov 02, 2024 at 03:50:43PM -0400, Aren Moynihan wrote:
> If the chip isn't powered, this call is likely to return an error.
> Without a log here the driver will silently fail to probe. Potential
> errors include ENXIO (when the chip isn't powered) and ETIMEDOUT (when
> the i2c bus isn't powered).
>
> This function is only called from stk3310_probe, and this condition
> should return an error, which fits what dev_err_probe is designed for.
...
> + return dev_err_probe(dev, ret, "failed to read chip id\n");
Please, make sure you have consistent style in the messages. Most of what
I have seen use period at the end. This one doesn't.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists