linux-kernel - Re: [PATCH 04/11] staging: gpib: Update messaging and usb_device refs in agilent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e51ffd6a-b002-40df-94c0-02eb8cbe8c76@stanley.mountain>
Date: Mon, 4 Nov 2024 11:42:42 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Dave Penkler <dpenkler@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
	arnd@...db.de
Subject: Re: [PATCH 04/11] staging: gpib: Update messaging and usb_device
 refs in agilent_usb

On Sun, Nov 03, 2024 at 10:26:10PM +0100, Dave Penkler wrote:
> Replace GPIB_DPRINTK with dev_dbg
> Replace pr_xxx with dev_xxx wherever possible
> Use previously initialized usb_device pointer for usb_put_dev()
> 
> Signed-off-by: Dave Penkler <dpenkler@...il.com>
> ---
>  .../gpib/agilent_82357a/agilent_82357a.c      | 266 ++++++++++--------
>  1 file changed, 156 insertions(+), 110 deletions(-)
> 
> diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
> index 748aadc5cebc..68b40831b9ad 100644
> --- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
> +++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
> @@ -15,11 +15,11 @@
>  #include "tms9914.h"
>  
>  MODULE_LICENSE("GPL");
> -MODULE_DESCRIPTION("GPIB driver for Agilent 82357A/B usb adapter");
> +MODULE_DESCRIPTION("GPIB driver for Agilent 82357A/B usb adapters");

This should go in a patch by itself.

>  
>  #define MAX_NUM_82357A_INTERFACES 128
>  static struct usb_interface *agilent_82357a_driver_interfaces[MAX_NUM_82357A_INTERFACES];
> -DEFINE_MUTEX(agilent_82357a_hotplug_lock);
> +DEFINE_MUTEX(agilent_82357a_hotplug_lock); // protect board insertion and removal


This too.

>  
>  static unsigned int agilent_82357a_update_status(gpib_board_t *board, unsigned int clear_mask);
>  
> @@ -29,9 +29,6 @@ static void agilent_82357a_bulk_complete(struct urb *urb)
>  {
>  	struct agilent_82357a_urb_ctx *context = urb->context;
>  
> -//	printk("debug: %s: status=0x%x, error_count=%i, actual_length=%i\n", __func__,
> -//		urb->status, urb->error_count, urb->actual_length);
> -
>  	up(&context->complete);
>  }
>  
> @@ -80,16 +77,17 @@ static int agilent_82357a_send_bulk_msg(struct agilent_82357a_priv *a_priv, void
>  	if (timeout_msecs)
>  		mod_timer(&a_priv->bulk_timer, jiffies + msecs_to_jiffies(timeout_msecs));
>  
> -	//printk("%s: submitting urb\n", __func__);
> +	//dev_dbg(&usb_dev->dev, "%s: submitting urb\n", __func__);

Just delete this.

regards,
dan carpenter