[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a8d9f32f60f55c58d79943c4409b8b94535ff853.camel@redhat.com>
Date: Mon, 04 Nov 2024 10:26:51 +0100
From: Philipp Stanner <pstanner@...hat.com>
To: Thomas Gleixner <tglx@...utronix.de>, Damien Le Moal
<dlemoal@...nel.org>, Niklas Cassel <cassel@...nel.org>, Sergey Shtylyov
<s.shtylyov@....ru>, Basavaraj Natikar <basavaraj.natikar@....com>, Jiri
Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>, Arnd
Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Alex Dubov <oakad@...oo.com>, Sudarsana Kalluru <skalluru@...vell.com>,
Manish Chopra <manishc@...vell.com>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rasesh Mody
<rmody@...vell.com>, GR-Linux-NIC-Dev@...vell.com, Igor Mitsyanko
<imitsyanko@...ntenna.com>, Sergey Matyukevich <geomatsi@...il.com>, Kalle
Valo <kvalo@...nel.org>, Sanjay R Mehta <sanju.mehta@....com>, Shyam Sundar
S K <Shyam-sundar.S-k@....com>, Jon Mason <jdmason@...zu.us>, Dave Jiang
<dave.jiang@...el.com>, Allen Hubbe <allenbh@...il.com>, Bjorn Helgaas
<bhelgaas@...gle.com>, Alex Williamson <alex.williamson@...hat.com>,
Juergen Gross <jgross@...e.com>, Stefano Stabellini
<sstabellini@...nel.org>, Oleksandr Tyshchenko
<oleksandr_tyshchenko@...m.com>, Jaroslav Kysela <perex@...ex.cz>, Takashi
Iwai <tiwai@...e.com>, Chen Ni <nichen@...as.ac.cn>, Mario Limonciello
<mario.limonciello@....com>, Ricky Wu <ricky_wu@...ltek.com>, Al Viro
<viro@...iv.linux.org.uk>, Breno Leitao <leitao@...ian.org>, Kevin Tian
<kevin.tian@...el.com>, Ilpo Järvinen
<ilpo.jarvinen@...ux.intel.com>, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com>, Mostafa Saleh <smostafa@...gle.com>,
Jason Gunthorpe <jgg@...pe.ca>, Yi Liu <yi.l.liu@...el.com>, Christian
Brauner <brauner@...nel.org>, Ankit Agrawal <ankita@...dia.com>, Eric Auger
<eric.auger@...hat.com>, Reinette Chatre <reinette.chatre@...el.com>, Ye
Bin <yebin10@...wei.com>, Marek Marczykowski-Górecki
<marmarek@...isiblethingslab.com>, Pierre-Louis Bossart
<pierre-louis.bossart@...ux.dev>, Peter Ujfalusi
<peter.ujfalusi@...ux.intel.com>, Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>, Kai Vehmanen
<kai.vehmanen@...ux.intel.com>, Rui Salvaterra <rsalvaterra@...il.com>
Cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-input@...r.kernel.org, netdev@...r.kernel.org,
linux-wireless@...r.kernel.org, ntb@...ts.linux.dev,
linux-pci@...r.kernel.org, kvm@...r.kernel.org,
xen-devel@...ts.xenproject.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 01/13] PCI: Prepare removing devres from pci_intx()
On Thu, 2024-10-31 at 14:45 +0100, Thomas Gleixner wrote:
> On Tue, Oct 15 2024 at 20:51, Philipp Stanner wrote:
> > +/**
> > + * pci_intx - enables/disables PCI INTx for device dev, unmanaged
> > version
>
> mismatch vs. actual function name.
ACK, will fix
>
> > + * @pdev: the PCI device to operate on
> > + * @enable: boolean: whether to enable or disable PCI INTx
> > + *
> > + * Enables/disables PCI INTx for device @pdev
> > + *
> > + * This function behavios identically to pci_intx(), but is never
> > managed with
> > + * devres.
> > + */
> > +void pci_intx_unmanaged(struct pci_dev *pdev, int enable)
>
> This is a misnomer. The function controls the INTX_DISABLE bit of a
> PCI device. Something like this:
>
> void __pci_intx_control()
> {
> }
>
> static inline void pci_intx_enable(d)
> {
> __pci_intx_control(d, true);
> }
>
> .....
>
> makes it entirely clear what this is about.
Well, I would agree if it were about writing a 'real' new function. But
this is actually about creating a _temporary_ function which is added
here and removed again in patch 12 of this same series.
It wouldn't even be needed; the only reason why it exists is to make it
easy for the driver maintainers concerned by patches 2-11 to review the
change and understand what's going on. Hence it is
"pci_intx_unmanaged()" == "Attention, we take automatic management away
from your driver"
pci_intx() is then fully restored after patch 12 and it keeps its old
name.
Grüße,
Philipp
>
> Hmm?
>
> Thanks,
>
> tglx
>
Powered by blists - more mailing lists