[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f6205012-5f5b-4613-bcb5-dea3f904b5a0@oss.qualcomm.com>
Date: Mon, 4 Nov 2024 10:38:51 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] firmware: qcom: scm: add modparam to control QSEECOM
enablement
On 3.11.2024 4:37 PM, Dmitry Baryshkov wrote:
> In preparation to enabling QSEECOM for the platforms rather than
> individual machines provide a mechanism for the user to override default
> selection. Allow users to use qcom_scm.qseecom modparam. Setting it to
> 'force' will enable QSEECOM even if it disabled or not handled by the
> allowlist. Setting it to 'off' will forcebly disable the QSEECOM
> interface, allowing incompatible machines to function. All other values
> mean 'auto', trusting the allowlist in the module.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> ---
[...]
>
> -static bool qcom_scm_qseecom_machine_is_allowed(void)
> +static bool qcom_scm_qseecom_machine_is_allowed(struct device *scm_dev)
> {
> struct device_node *np;
> bool match;
>
> + if (!strcmp(qseecom, "off")) {
> + dev_info(scm_dev, "qseecom: disabled by modparam\n");
> + return false;
> + } else if (!strcmp(qseecom, "force")) {
> + dev_info(scm_dev, "qseecom: forcebly enabled\n");
forcibly
may also be useful to say "by modparam" here as well
Konrad
Powered by blists - more mailing lists