linux-kernel - Re: [PATCH V4 1/4] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16aaae04-4fe8-4227-9374-0919960a4ca2@quicinc.com>
Date: Mon, 4 Nov 2024 15:51:36 +0530
From: Jishnu Prakash <quic_jprakash@...cinc.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: <quic_skakitap@...cinc.com>, <daniel.lezcano@...aro.org>,
        <andersson@...nel.org>, <lee@...nel.org>,
        <cros-qcom-dts-watchers@...omium.org>, <linux-kernel@...r.kernel.org>,
        <lars@...afoo.de>, <robh+dt@...nel.org>, <quic_subbaram@...cinc.com>,
        <rafael@...nel.org>, <quic_kamalw@...cinc.com>, <agross@...nel.org>,
        <amitk@...nel.org>, <linux-pm@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <dmitry.baryshkov@...aro.org>,
        <quic_amelende@...cinc.com>, <neil.armstrong@...aro.org>,
        <conor+dt@...nel.org>, <linux-iio@...r.kernel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <quic_collinsd@...cinc.com>,
        <konrad.dybcio@...aro.org>, <jic23@...nel.org>,
        <devicetree@...r.kernel.org>, <lukasz.luba@....com>,
        <rui.zhang@...el.com>, <sboyd@...nel.org>
Subject: Re: [PATCH V4 1/4] dt-bindings: iio/adc: Move QCOM ADC bindings to
 iio/adc folder

Hi Rob,

On 10/31/2024 1:50 AM, Rob Herring (Arm) wrote:
> 
> On Thu, 31 Oct 2024 00:28:51 +0530, Jishnu Prakash wrote:
>> There are several files containing QCOM ADC macros for channel names
>> right now in the include/dt-bindings/iio folder. Since all of these
>> are specifically for adc, move the files to the
>> include/dt-bindings/iio/adc folder.
>>
>> Also update all affected devicetree and driver files to fix compilation
>> errors seen with this move and update documentation files to fix
>> dtbinding check errors for the same.
>>
>> Acked-by: Lee Jones <lee@...nel.org>
>> Acked-by: Rob Herring <robh@...nel.org>
>> Signed-off-by: Jishnu Prakash <quic_jprakash@...cinc.com>
>> ---
>> Changes since v3:
>> - Updated files affected by adc file path change in /arch/arm, which
>>   were missed earlier. Updated some more new devicetree files requiring
>>   this change in /arch/arm64.
>>


>>  rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-smb139x.h (93%)
>>  rename include/dt-bindings/iio/{ => adc}/qcom,spmi-vadc.h (100%)
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> In file included from Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.example.dts:80:
> ./scripts/dtc/include-prefixes/dt-bindings/iio/adc/qcom,spmi-adc7-pmk8350.h:13:10: fatal error: dt-bindings/iio/adc/qcom,spmi-vadc.h: No such file or directory
>    13 | #include <dt-bindings/iio/adc/qcom,spmi-vadc.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I think there must be some mistake here because my patch does add the file include/dt-bindings/iio/adc/qcom,spmi-vadc.h, through a rename. This is seen at the very end of my patch:

> diff --git a/include/dt-bindings/iio/qcom,spmi-vadc.h b/include/dt-bindings/iio/adc/qcom,spmi-vadc.h
> similarity index 100%
> rename from include/dt-bindings/iio/qcom,spmi-vadc.h
> rename to include/dt-bindings/iio/adc/qcom,spmi-vadc.h

This patch moves our ADC-related header files from 'include/dt-bindings/iio/' folder to 'include/dt-bindings/iio/adc' folder
and fixes this path change in all affected files in the same patch....I think this should be expected to pass compilation.

Is it possible something went wrong from your end in this case? I see that both the files mentioned in the above error, qcom,spmi-adc7-pmk8350.h and qcom,spmi-vadc.h
are moved from 'include/dt-bindings/iio/' folder to 'include/dt-bindings/iio/adc' folder in my patch, could the tool be confused due to qcom,spmi-adc7-pmk8350.h
containing the updated path of qcom,spmi-vadc.h?


> compilation terminated.
> make[2]: *** [scripts/Makefile.dtbs:129: Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2
> make: *** [Makefile:224: __sub-make] Error 2
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241030185854.4015348-2-quic_jprakash@quicinc.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 

I have also followed the above instructions to update dt-schema and run 'make dt_binding_check' again and I did not see the above error.
I'm also not getting any errors when building with this patch applied.

Thanks,
Jishnu

> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>