linux-kernel - Re: [PATCH v2 8/9] KVM: x86: Unpack msr_data structure prior to calling kvm_apic_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3213afd28974933d7597238f4434c4589f89b2a3.camel@intel.com>
Date: Mon, 4 Nov 2024 10:28:56 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "pbonzini@...hat.com" <pbonzini@...hat.com>, "seanjc@...gle.com"
	<seanjc@...gle.com>
CC: "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 8/9] KVM: x86: Unpack msr_data structure prior to
 calling kvm_apic_set_base()

On Fri, 2024-11-01 at 11:35 -0700, Sean Christopherson wrote:
> Pass in the new value and "host initiated" as separate parameters to
> kvm_apic_set_base(), as forcing the KVM_SET_SREGS path to declare and fill
> an msr_data structure is awkward and kludgy, e.g. __set_sregs_common()
> doesn't even bother to set the proper MSR index.
> 
> No functional change intended.
> 
> Suggested-by: Kai Huang <kai.huang@...el.com>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> 


Reviewed-by: Kai Huang <kai.huang@...el.com>