linux-kernel - Re: [PATCH V3 3/3] arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbed68f8-ec8e-47e2-a2d7-e57363b23e20@oss.qualcomm.com>
Date: Mon, 4 Nov 2024 12:25:27 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Sibi Sankar <quic_sibis@...cinc.com>, andersson@...nel.org,
        konradybcio@...nel.org, krzk+dt@...nel.org, robh+dt@...nel.org,
        dmitry.baryshkov@...aro.org
Cc: linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, conor+dt@...nel.org, abel.vesa@...aro.org,
        srinivas.kandagatla@...aro.org, quic_jjohnson@...cinc.com,
        maz@...nel.org, jens.glathe@...schoolsolutions.biz
Subject: Re: [PATCH V3 3/3] arm64: dts: qcom: Add X1E001DE Snapdragon Devkit
 for Windows

On 25.10.2024 2:32 PM, Sibi Sankar wrote:
> Add initial support for x1e001de devkit platform. This includes:
> 
> -DSPs
> -Ethernet (RTL8125BG) over the pcie 5 instance.
> -NVme
> -Wifi
> -USB-C ports
> 
> Link: https://www.qualcomm.com/news/releases/2024/05/qualcomm-accelerates-development-for-copilot--pcs-with-snapdrago
> Signed-off-by: Sibi Sankar <quic_sibis@...cinc.com>
> ---

[...]

> +	vreg_nvme: regulator-nvme {
> +		compatible = "regulator-fixed";
> +
> +		regulator-name = "VREG_NVME_3P3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +
> +		gpio = <&tlmm 18 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&nvme_reg_en>;

these are backwards

otherwise lgtm

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad