linux-kernel - Re: [PATCH] efi: Fix memory leak in efivar_ssdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zyi11v-6V_ivKS5x@grain>
Date: Mon, 4 Nov 2024 14:53:58 +0300
From: Cyrill Gorcunov <gorcunov@...il.com>
To: LKML <linux-kernel@...r.kernel.org>, linux-efi@...r.kernel.org
Cc: Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH] efi: Fix memory leak in efivar_ssdt_load

On Mon, Nov 04, 2024 at 02:43:46PM +0300, Cyrill Gorcunov wrote:
> When we load ssdt from efi variable (specified with efivar_ssdt=something
> boot command line argument) a name for the variable is allocated
> dynamically because we traverse all efi variables. Unlike an acpi table
> data, which is later used by acpi engine, the name is no longer needed
> once traverse is complete -- don't forget to free this memory.

Drop it for a while: found that ret variable is shadowed while compiler
didn't spit a warn about, not a bug but better fix it. Will send v2.