lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ix34xln3tl6l2h3jt7t4bhrydxfmh2m53dkl5rugxj335p7hgb@kfauvwrusipr>
Date: Mon, 4 Nov 2024 14:24:43 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Laurentiu Palcu <laurentiu.palcu@....nxp.com>
Cc: Arnd Bergmann <arnd@...nel.org>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, Ville Syrjälä <ville.syrjala@...ux.intel.com>, 
	Arnd Bergmann <arnd@...db.de>, Lucas Stach <l.stach@...gutronix.de>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Shawn Guo <shawnguo@...nel.org>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	Fabio Estevam <festevam@...il.com>, Javier Martinez Canillas <javierm@...hat.com>, 
	dri-devel@...ts.freedesktop.org, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/imx/dcss: include drm/drm_bridge.h header

On Mon, Nov 04, 2024 at 02:10:54PM +0200, Laurentiu Palcu wrote:
> Hi Arnd,
> 
> On Mon, Oct 28, 2024 at 04:35:07PM +0000, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > Compile-testing random configurations leads to failures in
> > dcss-kms.c from a missing declaration:
> > 
> > drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach'
> >    95 |         ret = drm_bridge_attach(encoder, bridge, NULL,
> >       |               ^
> > drivers/gpu/drm/imx/dcss/dcss-kms.c:96:5: error: use of undeclared identifier 'DRM_BRIDGE_ATTACH_NO_CONNECTOR'
> >    96 |                                 DRM_BRIDGE_ATTACH_NO_CONNECTOR);
> >       |                                 ^
> > 
> > Include the header directly.
> > 
> > Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Reviewed-by: Laurentiu Palcu <laurentiu.palcu@....nxp.com>
> 
> Unfortunately, it appears I lost drm-misc push rights. Maxime, Thomas or
> Ville, can you help push this?

I can pick it up.

However I think it is:

Fixes: e7033bdfd43b ("drm/imx/dcss: use drm_bridge_connector API")

With that

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>


> 
> Thanks,
> Laurentiu
> 
> > ---
> >  drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> > index 3ec721afc30c..63a335c62296 100644
> > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
> > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> > @@ -5,6 +5,7 @@
> >  
> >  #include <drm/drm_atomic.h>
> >  #include <drm/drm_atomic_helper.h>
> > +#include <drm/drm_bridge.h>
> >  #include <drm/drm_bridge_connector.h>
> >  #include <drm/drm_client_setup.h>
> >  #include <drm/drm_drv.h>
> > -- 
> > 2.39.5
> > 

-- 
With best wishes
Dmitry

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ