linux-kernel - Re: [PATCH 4/6] Xarray: skip unneeded xas_store() and xas_clear_mark() in __xa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZyjNeq1GJTFFa3-7@casper.infradead.org>
Date: Mon, 4 Nov 2024 13:34:50 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Kemeng Shi <shikemeng@...weicloud.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 4/6] Xarray: skip unneeded xas_store() and
 xas_clear_mark() in __xa_alloc()

On Mon, Nov 04, 2024 at 09:55:42AM +0800, Kemeng Shi wrote:
> > No.  The point of the xas interfaces is that they turn into no-ops once
> > an error has occurred.
> Yes, xas interfaces can tolerate error. The question is do we really need to
> call xas_store(...) here if we already know there is no room to store new entry.
> But no insistant on this as it's not a big deal anyway.
> 
> Will drop this on next version if you still disklike this.

I very much dislike this.  The point is to make the callers simpler.