[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87h68nksfw.fsf@nvidia.com>
Date: Mon, 4 Nov 2024 15:00:03 +0100
From: Petr Machata <petrm@...dia.com>
To: "Matthieu Baerts (NGI0)" <matttbe@...nel.org>
CC: <mptcp@...ts.linux.dev>, "David S. Miller" <davem@...emloft.net>, "Eric
Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
Abeni" <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Shuah Khan
<shuah@...nel.org>, Mat Martineau <martineau@...nel.org>, Geliang Tang
<geliang@...nel.org>, Pablo Neira Ayuso <pablo@...filter.org>, "Jozsef
Kadlecsik" <kadlec@...filter.org>, Petr Machata <petrm@...dia.com>,
<netdev@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <netfilter-devel@...r.kernel.org>,
<coreteam@...filter.org>
Subject: Re: [PATCH net-next] selftests: net: include lib/sh/*.sh with lib.sh
"Matthieu Baerts (NGI0)" <matttbe@...nel.org> writes:
> Recently, the net/lib.sh file has been modified to include defer.sh from
> net/lib/sh/ directory. The Makefile from net/lib has been modified
> accordingly, but not the ones from the sub-targets using net/lib.sh.
>
> Because of that, the new file is not installed as expected when
> installing the Forwarding, MPTCP, and Netfilter targets, e.g.
>
> # make -C tools/testing/selftests TARGETS=net/mptcp install \
> INSTALL_PATH=/tmp/kself
> # cd /tmp/kself/
> # ./run_kselftest.sh -c net/mptcp
> TAP version 13
> 1..7
> # timeout set to 1800
> # selftests: net/mptcp: mptcp_connect.sh
> # ./../lib.sh: line 5: /tmp/kself/net/lib/sh/defer.sh: No such file
> or directory
> # (...)
>
> This can be fixed simply by adding all the .sh files from net/lib/sh
> directory to the TEST_INCLUDES variable in the different Makefile's.
>
> Fixes: a6e263f125cd ("selftests: net: lib: Introduce deferred commands")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
Gah, I knew moving this to a separate module would end up biting us.
Well, hopefully the wildcard takes care of this once and for all.
Thanks for the fix!
Reviewed-by: Petr Machata <petrm@...dia.com>
Powered by blists - more mailing lists