linux-kernel - Re: [PATCH net-next 5/5] net: phy: microchip_t1 : Add initialization of ptp for lan887x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c585168-20b0-4abe-b4f2-0d0949627bfe@lunn.ch>
Date: Mon, 4 Nov 2024 15:04:02 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Divya Koppera <divya.koppera@...rochip.com>
Cc: arun.ramadoss@...rochip.com, UNGLinuxDriver@...rochip.com,
	hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	richardcochran@...il.com
Subject: Re: [PATCH net-next 5/5] net: phy: microchip_t1 : Add initialization
 of ptp for lan887x

>  static int lan937x_dsp_workaround(struct phy_device *phydev, u16 ereg, u8 bank)
> @@ -1472,6 +1478,12 @@ static int lan887x_probe(struct phy_device *phydev)
>  
>  	phydev->priv = priv;
>  
> +	priv->clock = mchp_ptp_probe(phydev, MDIO_MMD_VEND1,
> +				     MCHP_PTP_LTC_BASE_ADDR,
> +				     MCHP_PTP_PORT_BASE_ADDR);

In general, PHY interrupts are optional, since phylib will poll the
PHY once per second for changes in link etc. Does mchp_ptp_probe() do
the right thing if the PHY does not have an interrupt?

	Andrew