linux-kernel - Re: [PATCH 2/2] rtlwifi: Remove more unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87msif6q4q.fsf@kernel.org>
Date: Mon, 04 Nov 2024 16:16:21 +0200
From: Kalle Valo <kvalo@...nel.org>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: pkshih@...ltek.com,  linux-wireless@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] rtlwifi: Remove more unused functions

"Dr. David Alan Gilbert" <linux@...blig.org> writes:

> * Kalle Valo (kvalo@...nel.org) wrote:
>> linux@...blig.org writes:
>> 
>> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
>> >
>> > exhalbtc_dbg_control(), exhalbtc_stack_update_profile_info(),
>> > exhalbtc_set_hci_version(), and exhalbtc_set_bt_patch_version() are
>> > unused since their addition in 2014 by
>> > commit aa45a673b291 ("rtlwifi: btcoexist: Add new mini driver")
>> >
>> > Remove them.
>> >
>> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
>> 
>> 'wifi:' missing.
>
> Oops, can add that.
>
>> Also in both patches the subject could be more unique.
>
> Do you have suggestions? I don't know the code to give good titles.
> They're both 'btcoexist'; I could merge them into one
>
> wifi: wtlwifi: Remove btcoexist deadcode

No good suggestions really. Usually I add what I'm removing to the
subject but as this patch is removing several functions the subject
would be too long. Maybe something like 'wifi: rtlwifi: remove several
unused exhalbtc_*() functions?' just to throw out some ideas, I'm sure
you can come with better ones.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches