linux-kernel - Re: [PATCH 0/5] PCI/pwrctl: Ensure that the pwrctl drivers are probed before PCI client drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241105001206.GA1447985@bhelgaas>
Date: Mon, 4 Nov 2024 18:12:06 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Krzysztof Wilczyński <kw@...ux.com>
Cc: manivannan.sadhasivam@...aro.org, Bjorn Helgaas <bhelgaas@...gle.com>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	Johan Hovold <johan+linaro@...nel.org>,
	Abel Vesa <abel.vesa@...aro.org>,
	Stephan Gerhold <stephan.gerhold@...aro.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
	stable+noautosel@...nel.org
Subject: Re: [PATCH 0/5] PCI/pwrctl: Ensure that the pwrctl drivers are
 probed before PCI client drivers

On Mon, Nov 04, 2024 at 05:31:07AM +0900, Krzysztof Wilczyński wrote:
> Hello,
> 
> > This series reworks the PCI/pwrctl integration to ensure that the pwrctl drivers
> > are always probed before the PCI client drivers. This series addresses a race
> > condition when both pwrctl and pwrctl/pwrseq drivers probe parallely (even when
> > the later one probes last). One such issue was reported for the Qcom X13s
> > platform with WLAN module and fixed with 'commit a9aaf1ff88a8 ("power:
> > sequencing: request the WLAN enable GPIO as-is")'.
> > 
> > Though the issue was fixed with a hack in the pwrseq driver, it was clear that
> > the issue is applicable to all pwrctl drivers. Hence, this series tries to
> > address the issue in the PCI/pwrctl integration.
> 
> Applied to bwctrl, thank you!

Should be pci/pwrctl.  bwctrl (bandwidth control) and pwrctl (power
control) are quite different despite the confusingly similar names.

> [01/05] PCI/pwrctl: Use of_platform_device_create() to create pwrctl devices
>         https://git.kernel.org/pci/pci/c/d2b6619e7419
> 
> [02/05] PCI/pwrctl: Create pwrctl devices only if at least one power supply is present
>         https://git.kernel.org/pci/pci/c/5f2710a4c275
> 
> [03/05] PCI/pwrctl: Ensure that the pwrctl drivers are probed before the PCI client drivers
>         https://git.kernel.org/pci/pci/c/4c963d4c13b9
> 
> [04/05] PCI/pwrctl: Move pwrctl device creation to its own helper function
>         https://git.kernel.org/pci/pci/c/73ae23a6af78
> 
> [05/05] PCI/pwrctl: Remove pwrctl device without iterating over all children of pwrctl parent
>         https://git.kernel.org/pci/pci/c/5ccc52fd1e5a
> 
> 	Krzysztof