linux-kernel - Re: [PATCH 2/3] i2c: pxa: Add check for clk_enable() and clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANeGvZXsw-93j7YrHd=aa4bWCLioE-LbT5kakc9gjeHCK6O+qQ@mail.gmail.com>
Date: Tue, 5 Nov 2024 11:26:42 -0500
From: Jiasheng Jiang <jiashengjiangcool@...il.com>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: rmk@...-67.arm.linux.org.uk, max.schwarz@...ine.de, dianders@...omium.org, 
	david.wu@...k-chips.com, heiko@...ech.de, vz@...ia.com, wsa@...nel.org, 
	manabian@...il.com, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] i2c: pxa: Add check for clk_enable() and clk_prepare_enable()

Hi Andi,

On Tue, Nov 5, 2024 at 9:13 AM Andi Shyti <andi.shyti@...nel.org> wrote:

> > Add check for the return values of clk_enable() and clk_prepare_enable()
> > in order to catch the potential exceptions.
> >
> > Fixes: e7d48fa2b5fb ("[I2C] pxa: provide late suspend and early resume hooks")
> > Fixes: c3cef3f3c07b ("[ARM] pxa: update pxa i2c driver to use clk support")
>
> I don't think we need the fixes tag here and nowhere else in this
> series.
>
> > Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...il.com>
> > ---
> >  drivers/i2c/busses/i2c-pxa.c | 14 ++++++++++++--
> >  1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
> > index 4d76e71cdd4b..1118a7f5c6bf 100644
> > --- a/drivers/i2c/busses/i2c-pxa.c
> > +++ b/drivers/i2c/busses/i2c-pxa.c
> > @@ -1503,7 +1503,11 @@ static int i2c_pxa_probe(struct platform_device *dev)
> >                               i2c->adap.name);
> >       }
> >
> > -     clk_prepare_enable(i2c->clk);
> > +     ret = clk_prepare_enable(i2c->clk);
> > +     if (ret) {
> > +             dev_err(&dev->dev, "failed to enable clock: %d\n", ret);
>
> please use dev_err_probe here.

Thanks, I have submitted a v2 series without the above problems.

-Jiasheng